Extend the existing provider creation with DDF support

[skateman]

@agrare created a new method on the amazon provider that creates a new record from the data submitted from a DDF. In order to keep backwards compatibility and also have the fancy POST /api/providers for creation, I added a test for a ddf attribute. If this attribute is set, the new creation method will be called and if not, the legacy one is executed. So it is necessary to pass a ddf: true attribute with the submitted values.

Parent issue: ManageIQ/manageiq#18818

@miq-bot assign @martinpovolny
cc @Hyperkid123 can you test it together with ManageIQ/manageiq-providers-amazon#580 in your code?

[Hyperkid123]

@skateman first thing on Monday

[Hyperkid123]

@skateman I am having an issue with submitting a zone:

error: {kind: "bad_request",…}
kind: "bad_request"
message: "Could not create the new provider - Zone(#47275658611780) expected, got "4" which is an instance of String(#47275612667420)"
klass: "Api::BadRequestError"

I am also getting this error in the amazon provider plugin when doing the options query (not on master only with Adams PR):

LoadError (Unable to autoload constant ManageIQ::Providers::Amazon::StorageManager::Ebs, expected /home/mmarosi/manageiq/manageiq-providers-amazon/app/models/manageiq/providers/amazon/storage_manager/ebs.rb to define it):

Maybe I am missing some other dependency?

[skateman]

No, I guess the zone field needs a dataType set to an integer and maybe its name should be zone_id instead of zone.

[skateman]

Umm, no ... you need the name of the zone, not the ID. See here https://github.com/ManageIQ/manageiq-providers-amazon/pull/580/files#diff-235184baadf210fc9a4d037d8ffa1c37R179

[skateman]

Also make sure you're loading Adam's PR mentioned above

[Hyperkid123]

Umm, no ... you need the name of the zone, not the ID. See here https://github.com/ManageIQ/manageiq-providers-amazon/pull/580/files#diff-235184baadf210fc9a4d037d8ffa1c37R179

What? Using the name instead of ID? I guess I can try it.

Also make sure you're loading Adam's PR mentioned above

I am using all the PRs mentioned

[skateman]

Okay, try it. The autoloading error is real, I sent it over to Adam. But he's on PTO this week.

[skateman]

@Hyperkid123 I made some changes, if you send the zone as a string, it goes further. I guess we need the list of the regions in that dropdown to send a correct one, because that's where it's failing now...

[Hyperkid123]

@skateman the regions currently are using the same values as in the original code. We can change that easily.

[skateman]

After some hacking around in the UI, I was able to create a form that uses this as an endpoint and successfully created a provider, so this is good to go @lpichler

I even added tests to make you happy 😉

[skateman]

@miq-bot add_label enhancement

[miq-bot]

Checked commit skateman@4139a83 with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🍪