Don't require authorization for OPTIONS #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CORS states that no authorization should be done in pre-flight requests. For the problematic Container Deployments collection, we will now render the sensitive data if authorized, but don't require authorization, rendering no data if none is stipulated.
abellotti
reviewed
Aug 9, 2017
| render_options(:container_deployments, ContainerDeploymentService.new.all_data) | ||
| if [HttpHeaders::MIQ_TOKEN, HttpHeaders::AUTH_TOKEN, "HTTP_AUTHORIZATION"].any? { |header| request.headers.include?(header) } | ||
| require_api_user_or_token | ||
| render_options(:container_deployments, ContainerDeploymentService.new.all_data) |
There was a problem hiding this comment.
Nice @imtayadeway !!
Can we move the logic in line 12 to a method in base_controller/authentication.rb ? maybe something like request_includes_authentication. Thanks.
There was a problem hiding this comment.
We could, although personally I think this is an anti-pattern and I don't want to promote re-use of it. I could extract a private method in this controller if you think this would be better?
There was a problem hiding this comment.
if you don't mind, private method for now would be good. Thanks!!
|
Thanks @imtayadeway for the update 🎵 will merge when 🍏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CORS states that no authorization should be done in pre-flight
requests. For the problematic Container Deployments collection, we
will now render the sensitive data if authorized, but don't require
authorization, rendering no data if none is stipulated.
@miq-bot add-label bug
@miq-bot assign @abellotti
/cc @jntullo