Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to configure use_ssl option #225

Merged

Conversation

mantaskujalis
Copy link
Contributor

Hello,

we are trying to configure our testing environment and got stuck on forced use_ssl option as mandatory. As specs runs only locally (via docker) we are having hard time getting ssl certificate.

This PR allows to configure use_ssl option in preproduction enviroment. Production would be left unconfigurable as I believe ssl forcing is good thing in production.
In preproduction env without setting use_ssl option it would also default to true unless value is explicitly assigned to false

@iulian03

@mantaskujalis mantaskujalis force-pushed the feature/configurable_use_ssl branch 2 times, most recently from 727a312 to 1f05465 Compare July 17, 2023 17:31
@mantaskujalis
Copy link
Contributor Author

@iulian03 maybe you had time to look into this?

@vikt3
Copy link

vikt3 commented Sep 6, 2023

@iulian03 any chance someone could look into these changes? Would really appreciate

@iulian03
Copy link
Contributor

iulian03 commented Sep 13, 2023

@mantaskujalis @vikt3
it looks good, sorry for the late response. Will merge it and release it soon :)

@silvianagh silvianagh changed the base branch from master to rel/3.17.0 September 20, 2023 13:07
@silvianagh silvianagh merged commit 3d6114a into Mangopay:rel/3.17.0 Sep 20, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants