Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ender-3 V2 / S1 DACAI LCD compatibility with custom UIs, improve LCD READMEs #880

Conversation

vlad-the-compiler
Copy link
Contributor

Description

This PR fixes the private asset bundle folder for DACAI LCDs, making them compatible with custom UIs.

The following modifications have been made to the DACAI private folder:

  • config.txt has been adjusted to allow the font sizes to match the DWIN display
    • Sourced from official Creality firmware
    • Text no longer draws out-of-bounds and now properly clears the background when it changes
  • truefont/font.ttf has been changed from SimSun (serif) to SimHei (sans-serif)
    • Sourced from official Creality firmware
    • Font has been edited to include the Marlin Icons, MarlinUI now draws the Forward, Back, Degree, Feed Rate, and Folder font icons correctly
  • The complete DWIN_SET graphics asset bundle has been converted into DACAI ZICO format
    • This brings the updated icons set to DACAI displays, allowing for custom UIs to render all icons correctly

Additionally, the README.md files for Ender-3 S1 and Ender-3 V2 LCD Files folders have been updated as follows:

  • Ender-3 V2 LCD Files/README.md:
    • Now includes a full guide to identify all 4 types of display units (DWIN, DACAI, SYNWIT / VIEWE, TJC), along with their known specs
    • Includes a per-display UI compatibility list
    • Separate instructions have been added for flashing DWIN and DACAI LCDs
  • The Ender-3 S1 LCD Files/README.md has been updated to a general notice regarding the different types of display, redirecting to the comprehensive Ender-3 V2 display family readme mentioned above

Benefits

The DACAI LCD files update ensures this display unit now works properly with all Creality UI-based custom interfaces, and with MarlinUI. Text and icons are now displayed properly.
Please note that MarlinUI in Landscape is still not possible on this display, as the DACAI unit appears to omit the API for display rotation.

The updated README.md files provide more information about the different types of displays, their compatibility with the different UIs, and ways to update them (where currently available).

Related Issues

Partially fixes MarlinFirmware/Marlin#25195
Rendering issues are resolved, Landscape is incompatible due to display API limitations or currently unknown opcodes.

@thinkyhead
Copy link
Member

Some of the JPGs are increasing in size although they are not changing graphically. @ellensp recently compressed the images with JPEG.io so any images that are increasing in size should probably be run through that filter again.

@mriscoc
Copy link

mriscoc commented Jan 14, 2023

Currently there are two SYNWIT/VIEWE display versions.
HAS_GCODE_PREVIEW must be disabled to use ProUI with SYNWIT/VIEWE
TJC displays can be used with ProUI, but no values are shown in the mesh viewer due to missing small fonts.

@ellensp
Copy link
Contributor

ellensp commented Jan 14, 2023

@mriscoc any chance you could update your page so the images are clickable to a larger image, not all of us have 20/20 vision...
Or just a link to a high res image...

@EvilGremlin
Copy link
Contributor

EvilGremlin commented Jan 14, 2023

I think we should pull this page both into general marlin docs and into creality conf directory.
Also move screen assets up from e3v2 dir.

@mriscoc
Copy link

mriscoc commented Jan 14, 2023

@mriscoc any chance you could update your page so the images are clickable to a larger image, not all of us have 20/20 vision... Or just a link to a high res image...

I will try to do it, but users give me low-res images.

@EvilGremlin
Copy link
Contributor

I think @InsanityAutomation can make decent photos for all of them

@thinkyhead thinkyhead force-pushed the import-2.1.x-e2v2s1-dacai-marlinui-assets branch from fba3a13 to 0bfbf05 Compare January 15, 2023 15:56
@thinkyhead thinkyhead merged commit c116c29 into MarlinFirmware:import-2.1.x Jan 15, 2023
@mriscoc
Copy link

mriscoc commented Mar 31, 2023

@mriscoc any chance you could update your page so the images are clickable to a larger image,

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Ender 3 V2 with DACAI LCD not working with Landscape
5 participants