Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove FLYmaker FLY Mini Maple Environment Option #22359

Conversation

thisiskeithb
Copy link
Member

Description

The FLY Mini did not get a *_maple environment (80ef74d), but the option was added in #22356.

Benefits

Users will no longer be presented with an invalid environment when building for this board.

Related Issues

#22355
#22356

@ellensp
Copy link
Contributor

ellensp commented Jul 14, 2021

Just add it back in

#
# FLY MINI(stm32f103rct6)
#
[env:FLY_MINI_maple]
platform          = ${common_stm32f1.platform}
extends           = common_stm32f1
board             = genericSTM32F103RC
board_build.address  = 0x08005000
board_build.ldscript = fly_mini.ld
extra_scripts     = ${common_stm32f1.extra_scripts}
  buildroot/share/PlatformIO/scripts/custom_board.py
build_flags       = ${common_stm32f1.build_flags}
 -DDEBUG_LEVEL=0 -DSS_TIMER=4

@thisiskeithb
Copy link
Member Author

Just add it back in

Thinkyhead removed it in the referenced commit in my last PR, so I didn’t add it back again here.

@ellensp
Copy link
Contributor

ellensp commented Jul 14, 2021

that don't make sense, to new to remove maple totally for this board.
non maple isnt even a day old

@thisiskeithb
Copy link
Member Author

that don't make sense, to new to remove maple totally for this board.
non maple isnt even a day old

I didn't remove it. I don't know what to tell you.

@ellensp
Copy link
Contributor

ellensp commented Jul 14, 2021

Oh well, will wait to see what he says on this PR

@thinkyhead
Copy link
Member

It's difficult to decipher what your intentions are when you post competing PRs addressing the same thing and then leave them both up. From the comments on those two PRs it looked like you had decided to throw away the Maple target.

@thisiskeithb
Copy link
Member Author

It's difficult to decipher what your intentions are when you post competing PRs addressing the same thing and then leave them both up. From the comments on those two PRs it looked like you had decided to throw away the Maple target.

I'll submit a new PR to add the maple target back in.

@thisiskeithb thisiskeithb deleted the pr/remove_fly_mini_maple branch July 14, 2021 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants