[Network-controller-upgrade] Remove Feature Flag and Fix E2E Tests #11233
Assignees
Labels
INVALID-ISSUE-TEMPLATE
Issue's body doesn't match any issue template.
Comments
metamaskbot
added
the
INVALID-ISSUE-TEMPLATE
7 tasks
This was referenced Oct 7, 2024
Closed
github-merge-queue bot
pushed a commit
that referenced
this issue
Oct 11, 2024
…etworks with Distinct ChainIDs and Multiple RPC URLs (#11705) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** This PR refactors our network configuration to eliminate the use of multiple networks with the same ChainID but different RPC URLs. Instead, we are moving towards a setup where each network is uniquely identified by a distinct ChainID and can have multiple RPC URLs associated with it. This PR includes three merge commits. The first primarily addresses the Network Controller upgrade, as outlined in issue #[11229](#11229). The second commit contains the script for migrating the state to v21, and the third commit includes all the UI changes along with the fix for the e2e tests. For more details, please refer to [this](https://github.com/orgs/MetaMask/projects/120/views/1) . related PRs: - #11292 - #11622 - #11436 <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Related issues** Fixes: #[11229](#11229) #[11232](#11232) #[11234](#11234) #11233 ## **Manual testing steps** 1. Go to add network flow and test ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** https://drive.google.com/drive/folders/149Xji42k5of5Vl8nBlI0pFYFgPnWqILH?usp=drive_link <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This issue involves removing the feature flag
MM_NETWORK_UI_REDESIGN_ENABLEDthat currently gates the UI changes and ensuring that all end-to-end (E2E) tests are updated and passing. The feature flag was initially introduced to control the rollout of the new UI changes. With the feature now stable, it is time to remove the flag and make the changes permanent.Tasks:
Remove Feature Flag:
Identify all instances of the feature flag in the codebase.
Remove the feature flag checks and ensure that the new UI changes are always enabled.
Clean up any related code that is no longer necessary.
Update E2E Tests:
Review all existing E2E tests to ensure they are compatible with the new UI changes.
Update the tests to remove any dependencies on the feature flag.
Add new E2E tests if necessary to cover any new functionality introduced by the UI changes.
Run and Fix E2E Tests:
Run the full suite of E2E tests to identify any failing tests.
Fix any issues identified during the test run to ensure all tests pass.
Ensure that the tests cover all critical user flows and edge cases.
The text was updated successfully, but these errors were encountered: