Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add different channel IDs for Android Notifications #11415

Closed
1 of 9 tasks
Jonathansoufer opened this issue Sep 24, 2024 · 0 comments · Fixed by #11427
Closed
1 of 9 tasks

Add different channel IDs for Android Notifications #11415

Jonathansoufer opened this issue Sep 24, 2024 · 0 comments · Fixed by #11427
Assignees
@Jonathansoufer
Labels
release-7.33.0 Issue or pull request that will be included in release 7.33.0

Comments

@Jonathansoufer
Copy link
Contributor

What is this about?

This adds a ANNOUNCEMENT_NOTIFICATION_CHANNEL_ID for AndroidChannels so in the future we can handle announcement notifications

Scenario

No response

Design

No response

Technical Details

No response

Threat Modeling Framework

No response

Acceptance Criteria

No response

Stakeholder review needed before the work gets merged

  • Engineering (needed in most cases)
  • Design
  • Product
  • QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
  • Security
  • Legal
  • Marketing
  • Management (please specify)
  • Other (please specify)

References

No response
@Jonathansoufer Jonathansoufer self-assigned this Sep 24, 2024
This was referenced Sep 24, 2024
Merged
Merged
github-merge-queue bot pushed a commit that referenced this issue Sep 25, 2024
@Jonathansoufer
feat: add feature announcements channel for android (#11427)
6036bcb 
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

This PR adds ANNOUNCEMENT_NOTIFICATION_CHANNEL_ID for AndroidChannels.

## **Related issues**

Fixes: [11415](#11415)

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [x] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [x] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@metamaskbot metamaskbot added the release-7.33.0 Issue or pull request that will be included in release 7.33.0 label Sep 25, 2024
devin-ai-integration bot pushed a commit that referenced this issue Sep 25, 2024
@Jonathansoufer @devin-ai-integration
feat: add feature announcements channel for android (#11427)
4fe28c7 
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

This PR adds ANNOUNCEMENT_NOTIFICATION_CHANNEL_ID for AndroidChannels.

## **Related issues**

Fixes: [11415](#11415)

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [x] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [x] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jonathansoufer Jonathansoufer

Labels
release-7.33.0 Issue or pull request that will be included in release 7.33.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add feature announcements channel for android MetaMask/metamask-mobile
2 participants
@metamaskbot @Jonathansoufer