Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add timeout handler #11429

Merged

Conversation

Jonathansoufer
Copy link
Contributor

Description

This PR adds a withTimeout wrapper on notifee async calls to avoid get blocked in case a call doesn't resolve quickly.

This was a comment from this PR

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Jonathansoufer Jonathansoufer added No QA Needed Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform No E2E Smoke Needed If the PR does not need E2E smoke test run team-notifications Notifications team labels Sep 25, 2024
@Jonathansoufer Jonathansoufer self-assigned this Sep 25, 2024
@Jonathansoufer Jonathansoufer requested review from a team as code owners September 25, 2024 10:11
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions bot added the team-snaps-platform Snaps Platform team label Sep 25, 2024
Copy link

sonarcloud bot commented Sep 25, 2024

@Jonathansoufer Jonathansoufer added this pull request to the merge queue Sep 25, 2024
Merged via the queue into main with commit 964f151 Sep 25, 2024
36 checks passed
@Jonathansoufer Jonathansoufer deleted the feat/add-withTimeout-usage-on-notifee-async-calls branch September 25, 2024 18:22
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Sep 25, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 25, 2024
@metamaskbot metamaskbot added the release-7.33.0 Issue or pull request that will be included in release 7.33.0 label Sep 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No E2E Smoke Needed If the PR does not need E2E smoke test run No QA Needed Apply this label when your PR does not need any QA effort. release-7.33.0 Issue or pull request that will be included in release 7.33.0 team-mobile-platform team-notifications Notifications team team-snaps-platform Snaps Platform team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants