Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: react native quick crypto ios build bug #11443

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

Jonathansoufer
Copy link
Contributor

@Jonathansoufer Jonathansoufer commented Sep 25, 2024

Description

This PR fixes a bug introduces on iOS builds using react-native-quick-crypto as documented here

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Successful build: https://app.bitrise.io/build/076ad837-6e35-4165-a4f2-14c5754ad1d3

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Jonathansoufer Jonathansoufer added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform Run Smoke E2E Triggers smoke e2e on Bitrise labels Sep 25, 2024
@Jonathansoufer Jonathansoufer self-assigned this Sep 25, 2024
@Jonathansoufer Jonathansoufer requested review from a team as code owners September 25, 2024 17:26
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions bot added the team-snaps-platform Snaps Platform team label Sep 25, 2024
@Jonathansoufer Jonathansoufer changed the title Fix/react native quick crypto ios build bug fix: react native quick crypto ios build bug Sep 25, 2024
Copy link
Contributor

github-actions bot commented Sep 25, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 0658012
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/46e61533-f9a8-423e-a88f-c5fcee43a587

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

sonarcloud bot commented Sep 25, 2024

@sethkfman sethkfman removed team-mobile-platform needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Sep 25, 2024
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jonathansoufer Jonathansoufer added this pull request to the merge queue Sep 25, 2024
Merged via the queue into main with commit 36eade5 Sep 25, 2024
61 of 62 checks passed
@Jonathansoufer Jonathansoufer deleted the fix/react-native-quick-crypto-ios-build-bug branch September 25, 2024 18:38
@github-actions github-actions bot locked and limited conversation to collaborators Sep 25, 2024
@metamaskbot metamaskbot added the release-7.33.0 Issue or pull request that will be included in release 7.33.0 label Sep 25, 2024
ios/Podfile Show resolved Hide resolved
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.33.0 Issue or pull request that will be included in release 7.33.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-snaps-platform Snaps Platform team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants