Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: connect request completed source validation #11701

Merged
merged 4 commits into from
Oct 10, 2024

Conversation

elefantel
Copy link
Contributor

@elefantel elefantel commented Oct 9, 2024

Description

The Connect Request Completed analytics event had a wrong source walletconnect when a dapp was connecting to the wallet from the in-app browser. This PR fixes source the validation.

Related issues

Fixes: SDK-81

Manual testing steps

  1. Connect from a dapp within the in-app browser
  2. Observe Request Completed` analytics event being logged

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@elefantel elefantel added No QA Needed Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Oct 9, 2024
@elefantel elefantel self-assigned this Oct 9, 2024
@elefantel elefantel requested a review from a team as a code owner October 9, 2024 09:12
Copy link
Contributor

github-actions bot commented Oct 9, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions bot added the team-sdk SDK team label Oct 9, 2024
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Oct 9, 2024
@elefantel elefantel removed the INVALID-PR-TEMPLATE PR's body doesn't match template label Oct 9, 2024
Copy link

sonarcloud bot commented Oct 10, 2024

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 54.21%. Comparing base (5b1d54a) to head (61e9a05).
Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
...components/Views/AccountConnect/AccountConnect.tsx 0.00% 1 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11701      +/-   ##
==========================================
+ Coverage   54.07%   54.21%   +0.14%     
==========================================
  Files        1689     1709      +20     
  Lines       38546    38707     +161     
  Branches     4707     4736      +29     
==========================================
+ Hits        20844    20986     +142     
- Misses      16264    16272       +8     
- Partials     1438     1449      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elefantel elefantel added this pull request to the merge queue Oct 10, 2024
Merged via the queue into main with commit 562e5ed Oct 10, 2024
37 checks passed
@elefantel elefantel deleted the connect-request-completed-source branch October 10, 2024 18:33
@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.34.0 team-sdk SDK team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

7 participants