Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: token list after switching networks #11718

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Conversation

bergeron
Copy link
Contributor

@bergeron bergeron commented Oct 9, 2024

Description

Fixes an issue where after switching networks, importing a token populates search results from the old network.

The fix is to patch MetaMask/core#4316, which will be introduced in asset controllers version 33.

Related issues

Fixes: #11696

Manual testing steps

  1. Force close MM app
  2. Open MM
  3. Switch networks
  4. click import tokens
  5. search for a token by name, like usdt
  6. the imported token should have prices available and have the correct contract address

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Oct 9, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@bergeron bergeron changed the title fix token list controller switching networks fix: token list after switching networks Oct 9, 2024
@devin-ai-integration devin-ai-integration bot added team-mobile-platform needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) No QA Needed Apply this label when your PR does not need any QA effort. labels Oct 9, 2024
@bergeron bergeron marked this pull request as ready for review October 9, 2024 20:06
@bergeron bergeron requested a review from a team as a code owner October 9, 2024 20:06
Copy link

sonarcloud bot commented Oct 9, 2024

@Cal-L Cal-L enabled auto-merge October 9, 2024 22:08
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cal-L Cal-L added this pull request to the merge queue Oct 9, 2024
Merged via the queue into main with commit 3ebaa66 Oct 9, 2024
37 checks passed
@Cal-L Cal-L deleted the brian/patch-token-list-controller branch October 9, 2024 22:41
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.34.0 team-assets team-mobile-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Bug]: Import token search results returns tokens with incorrect contract address for selected network
4 participants