Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use domain for origin pill component #11730

Merged
merged 6 commits into from
Oct 11, 2024
Merged

Conversation

vinistevam
Copy link
Contributor

@vinistevam vinistevam commented Oct 10, 2024

Description

This PR fixes an issue where the full URL is displayed in the origin pill for transaction requests triggered from a dapp within the in-app browser, rather than just the domain. The expected behavior is to display only the domain, similar to how signature requests are handled. This update ensures consistency across both transaction and signature requests.

Related issues

Fixes: #11690

Manual testing steps

  1. Open a dapp within the in app browser
  2. Trigger a transaction request
  3. See the origin pill

Screenshots/Recordings

origin.webm

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@vinistevam vinistevam added the team-confirmations Push issues to confirmations team label Oct 10, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@vinistevam vinistevam changed the title Fix: Use domain for origin pill component fix: Use domain for origin pill component Oct 10, 2024
@vinistevam vinistevam marked this pull request as ready for review October 10, 2024 08:11
@vinistevam vinistevam requested review from a team as code owners October 10, 2024 08:11
@vinistevam vinistevam added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 10, 2024
Copy link
Contributor

github-actions bot commented Oct 10, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: a69d7e7
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3e1e95d1-6019-4d15-876f-b57d9c4b9fee

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

jpuri
jpuri previously approved these changes Oct 10, 2024
OGPoyraz
OGPoyraz previously approved these changes Oct 10, 2024
Copy link

sonarcloud bot commented Oct 11, 2024

@vinistevam vinistevam added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 11, 2024
Copy link
Contributor

github-actions bot commented Oct 11, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: fce42bb
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9ee57329-3271-463c-a239-a72c135b8f28

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@vinistevam vinistevam added this pull request to the merge queue Oct 11, 2024
Merged via the queue into main with commit 3774729 Oct 11, 2024
43 checks passed
@vinistevam vinistevam deleted the fix/full-url-confirmations branch October 11, 2024 12:00
@github-actions github-actions bot locked and limited conversation to collaborators Oct 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Full url is show instead of domain only on origin pill
5 participants