chore: Remove obsolete CI step #11756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI has a step where it sets up an alternative registry for `@metamask`- scoped packages specifically for draft PRs. This was intended to support the older stype of `MetaMask/core` preview builds, which used an alternative npm registry. Preview builds today now use the normal npm registry, so this step is no longer needed.
Gudahtt
added
No QA Needed
|
cortisiko
approved these changes
Oct 11, 2024
github-actions
bot
removed
the
needs-dev-review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CI has a step where it sets up an alternative registry for
@metamask- scoped packages specifically for draft PRs. This was intended to support the older stype ofMetaMask/corepreview builds, which used an alternative npm registry. Preview builds today now use the normal npm registry, so this step is no longer needed.Related issues
Originally added here: #5270
Some related changes here: #5807 (these were already removed)
The old preview build method was replaced here: MetaMask/core#1622
Manual testing steps
N/A
Screenshots/Recordings
N/A
Pre-merge author checklist
Pre-merge reviewer checklist