Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/use escape key to close documents modal #2222

Merged

Conversation

timothycarambat
Copy link
Member

@timothycarambat timothycarambat commented Sep 4, 2024

Pull Request Type

  • ✨ feat
  • πŸ› fix
  • ♻️ refactor
  • πŸ’„ style
  • πŸ”¨ chore
  • πŸ“ docs

Relevant Issues

Original PR: #2221 by @MrSimonC
resolves #2220

What is in this change?

This pull request adds the ability to close the modal dialogue for selecting documents in workspaces using the Escape key on the keyboard. Specifically, the changes include:

  • Adding an event listener to the modal dialogue to listen for the Escape key press event.
  • Closing the modal dialogue when the Escape key is pressed.

This change provides an additional option for users to dismiss the modal, improving the overall user experience and efficiency.

Additional Information

This change addresses a feature request to improve the workflow for users who work with multiple workspaces and need to quickly switch between them. By allowing the Escape key to close the modal, users can reduce mouse movement and streamline their workflow. This change does not introduce any breaking changes or affect existing functionality.

Developer Validations

  • I ran yarn lint from the root of the repo & committed changes
  • Relevant documentation has been updated
  • I have tested my code functionality
  • Docker build succeeds locally

@timothycarambat timothycarambat merged commit aa4c953 into master Sep 4, 2024
@timothycarambat timothycarambat deleted the feature/use-escape-key-to-close-documents-modal branch September 4, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT]: Add Escape Key to Close Workspace Document Modal Dialogue
2 participants