Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify indexes in TodoFile modify functions #441

Merged
merged 1 commit into from
Mar 11, 2021

Conversation

MitMaro
Copy link
Owner

@MitMaro MitMaro commented Mar 11, 2021

Description

Calling the various list modification functions in TodoFile without of range index values would cause a crash. This updates those functions to properly handle the cases where the provided indexes are out of range.

Calling the various list modification functions in TodoFile with an out
of range index values would cause a crash. This updates those functions
to properly handle the cases where the provided indexes are out of
range.
@MitMaro MitMaro self-assigned this Mar 11, 2021
@coveralls
Copy link

Pull Request Test Coverage Report for Build 641377185

  • 29 of 33 (87.88%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.08%) to 91.204%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/todo_file/mod.rs 27 31 87.1%
Totals Coverage Status
Change from base Build 641253591: -0.08%
Covered Lines: 2758
Relevant Lines: 3024

💛 - Coveralls

@MitMaro MitMaro merged commit 138f9c2 into master Mar 11, 2021
@MitMaro MitMaro deleted the mitmaro/todo-file-modify-index-range-bounds-checks branch March 11, 2021 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants