Skip to content
This repository has been archived by the owner on Aug 21, 2023. It is now read-only.

Adds Flavor Text #48

Merged
merged 7 commits into from
Jan 16, 2022
Merged

Adds Flavor Text #48

merged 7 commits into from
Jan 16, 2022

Conversation

Zonespace27
Copy link

@Zonespace27 Zonespace27 commented Jan 10, 2022

About The Pull Request

Adds flavor text to characters! You can have up to 512 characters, and is visible on-examine IF you are not marked as an unknown AND your name matches your real_name. For extra fun, you can |italicize|, +bold+, and underline your flavor text.
Code partially lifted from Donkstation and rewritten to fix HTML encoding exploits and adding the aforementioned special text.

Why It's Good For The Game

It gives more depth to characters, it feels sorta required for a living, breathing character.

Changelog

🆑
add: Flavor text has been added! Edit it in character setup.
/:cl:

@Merlin1230 Merlin1230 self-requested a review January 10, 2022 12:59
@nednaZ
Copy link
Member

nednaZ commented Jan 11, 2022

Works for me.
Different IDs and face coverings all prevent flavor text from being shown, so disguises should still function.

Only request is for the input box to have some kind of reference for the text modifiers.

@Zonespace27
Copy link
Author

Works for me. Different IDs and face coverings all prevent flavor text from being shown, so disguises should still function.

Only request is for the input box to have some kind of reference for the text modifiers.

Done

@nednaZ nednaZ added the Feature adds something new to the game label Jan 11, 2022
@nednaZ nednaZ self-requested a review January 13, 2022 20:21
Copy link
Member

@nednaZ nednaZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like the best method we can get for flavor text without having too many metagamer issues.
Approved for merge from me.

@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@lmenvs lmenvs merged commit 040b7ff into Monkestation:master Jan 16, 2022
@Zonespace27 Zonespace27 deleted the flavor_text branch January 16, 2022 20:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Feature adds something new to the game
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants