Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update code export and naming to make README example work #15

Merged
merged 1 commit into from
May 27, 2023
Merged

fix: update code export and naming to make README example work #15

merged 1 commit into from
May 27, 2023

Conversation

MarkusSagen
Copy link
Contributor

PR makes fixes to that the code example in the README will work

  • moves naming of files to python standard lowercase and for python not to be confused if something is imported as a module or class
  • fixed linting

MrBlenny
MrBlenny approved these changes May 27, 2023
View reviewed changes
Copy link
Owner

@MrBlenny MrBlenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great additions. Thanks for your contribution @MarkusSagen 🙂

@MrBlenny MrBlenny merged commit a4ee1f5 into MrBlenny:main May 27, 2023
@marlinstrub marlinstrub mentioned this pull request Oct 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrBlenny MrBlenny MrBlenny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarkusSagen @MrBlenny