This repository has been archived by the owner on Sep 24, 2023. It is now read-only.
2.1.0 patch8 issue 127 #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MurdoMaclachlan
added
the
cleanup/optimisation
10 tasks
There's no real reason to do this as they come out as the same due to Reddit's API limitations, and removing the `None` conversion allows an optimisation in `main.py`.
- Calling comment.body once in main.py and simply passing the body into all these functions significantly reduces the number of calls - Re-arranging how checkArray() works and splitting the if statement in remover() will utilise Python's lazy evaluation to reduce the number of API calls for people with subredditList and userList disabled - Also improved the typing of some functions
This was
linked to
issues
Oct 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #127
Contributes to #136