-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load ub_cfg from hydra config #7003
Conversation
Signed-off-by: Jan Baczek <jbaczek@nvidia.com>
Signed-off-by: Jan Baczek <jbaczek@nvidia.com>
Signed-off-by: Jan Baczek <jbaczek@nvidia.com>
@ericharper can you review this PR? |
for more information, see https://pre-commit.ci
Signed-off-by: Jan Baczek <jbaczek@nvidia.com>
for more information, see https://pre-commit.ci
LGTM Please assign me and @ericharper as the reviewers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
nemo/collections/nlp/models/language_modeling/megatron_gpt_model.py
Outdated
Show resolved
Hide resolved
@ericharper Can you review this PR? This looks good to me but should be good to have your feedback as well. |
@jbaczek |
@erhoo82 can you elaborate? What command did you type? What is your conf directory structure? |
Signed-off-by: Jan Baczek <jbaczek@nvidia.com>
Signed-off-by: yaoyu-33 <54727607+yaoyu-33@users.noreply.github.com>
for more information, see https://pre-commit.ci
Signed-off-by: Jan Baczek <jbaczek@nvidia.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the guard !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
* Pass tp config via hydra Signed-off-by: Jan Baczek <jbaczek@nvidia.com> * Remove self.ub_cfgs field - it isn't used anywhere else Signed-off-by: Jan Baczek <jbaczek@nvidia.com> * Allow tp_overlap tree substitution in hydra config Signed-off-by: Jan Baczek <jbaczek@nvidia.com> * Add warning in case of usage of the default tp config * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Change warning message Signed-off-by: Jan Baczek <jbaczek@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Add compute capability resolver Signed-off-by: Jan Baczek <jbaczek@nvidia.com> * Bugfix Signed-off-by: Jan Baczek <jbaczek@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * add guards to pynvml import Signed-off-by: Jan Baczek <jbaczek@nvidia.com> --------- Signed-off-by: Jan Baczek <jbaczek@nvidia.com> Signed-off-by: yaoyu-33 <54727607+yaoyu-33@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: yaoyu-33 <54727607+yaoyu-33@users.noreply.github.com>
* Pass tp config via hydra Signed-off-by: Jan Baczek <jbaczek@nvidia.com> * Remove self.ub_cfgs field - it isn't used anywhere else Signed-off-by: Jan Baczek <jbaczek@nvidia.com> * Allow tp_overlap tree substitution in hydra config Signed-off-by: Jan Baczek <jbaczek@nvidia.com> * Add warning in case of usage of the default tp config * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Change warning message Signed-off-by: Jan Baczek <jbaczek@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Add compute capability resolver Signed-off-by: Jan Baczek <jbaczek@nvidia.com> * Bugfix Signed-off-by: Jan Baczek <jbaczek@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * add guards to pynvml import Signed-off-by: Jan Baczek <jbaczek@nvidia.com> --------- Signed-off-by: Jan Baczek <jbaczek@nvidia.com> Signed-off-by: yaoyu-33 <54727607+yaoyu-33@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: yaoyu-33 <54727607+yaoyu-33@users.noreply.github.com> Signed-off-by: dorotat <dorotat@nvidia.com>
* Pass tp config via hydra Signed-off-by: Jan Baczek <jbaczek@nvidia.com> * Remove self.ub_cfgs field - it isn't used anywhere else Signed-off-by: Jan Baczek <jbaczek@nvidia.com> * Allow tp_overlap tree substitution in hydra config Signed-off-by: Jan Baczek <jbaczek@nvidia.com> * Add warning in case of usage of the default tp config Signed-off-by: Jan Baczek <jbaczek@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Signed-off-by: Jan Baczek <jbaczek@nvidia.com> * Change warning message Signed-off-by: Jan Baczek <jbaczek@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Signed-off-by: Jan Baczek <jbaczek@nvidia.com> * Add compute capability resolver Signed-off-by: Jan Baczek <jbaczek@nvidia.com> * Bugfix Signed-off-by: Jan Baczek <jbaczek@nvidia.com> * Fix cherry pick Signed-off-by: Jan Baczek <jbaczek@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Signed-off-by: Jan Baczek <jbaczek@nvidia.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* Pass tp config via hydra Signed-off-by: Jan Baczek <jbaczek@nvidia.com> * Remove self.ub_cfgs field - it isn't used anywhere else Signed-off-by: Jan Baczek <jbaczek@nvidia.com> * Allow tp_overlap tree substitution in hydra config Signed-off-by: Jan Baczek <jbaczek@nvidia.com> * Add warning in case of usage of the default tp config Signed-off-by: Jan Baczek <jbaczek@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Signed-off-by: Jan Baczek <jbaczek@nvidia.com> * Change warning message Signed-off-by: Jan Baczek <jbaczek@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Signed-off-by: Jan Baczek <jbaczek@nvidia.com> * Add compute capability resolver Signed-off-by: Jan Baczek <jbaczek@nvidia.com> * Bugfix Signed-off-by: Jan Baczek <jbaczek@nvidia.com> * Fix cherry pick Signed-off-by: Jan Baczek <jbaczek@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Signed-off-by: Jan Baczek <jbaczek@nvidia.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* Pass tp config via hydra Signed-off-by: Jan Baczek <jbaczek@nvidia.com> * Remove self.ub_cfgs field - it isn't used anywhere else Signed-off-by: Jan Baczek <jbaczek@nvidia.com> * Allow tp_overlap tree substitution in hydra config Signed-off-by: Jan Baczek <jbaczek@nvidia.com> * Add warning in case of usage of the default tp config Signed-off-by: Jan Baczek <jbaczek@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Signed-off-by: Jan Baczek <jbaczek@nvidia.com> * Change warning message Signed-off-by: Jan Baczek <jbaczek@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Signed-off-by: Jan Baczek <jbaczek@nvidia.com> * Add compute capability resolver Signed-off-by: Jan Baczek <jbaczek@nvidia.com> * Bugfix Signed-off-by: Jan Baczek <jbaczek@nvidia.com> * Fix cherry pick Signed-off-by: Jan Baczek <jbaczek@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Signed-off-by: Jan Baczek <jbaczek@nvidia.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* Pass tp config via hydra Signed-off-by: Jan Baczek <jbaczek@nvidia.com> * Remove self.ub_cfgs field - it isn't used anywhere else Signed-off-by: Jan Baczek <jbaczek@nvidia.com> * Allow tp_overlap tree substitution in hydra config Signed-off-by: Jan Baczek <jbaczek@nvidia.com> * Add warning in case of usage of the default tp config * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Change warning message Signed-off-by: Jan Baczek <jbaczek@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Add compute capability resolver Signed-off-by: Jan Baczek <jbaczek@nvidia.com> * Bugfix Signed-off-by: Jan Baczek <jbaczek@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * add guards to pynvml import Signed-off-by: Jan Baczek <jbaczek@nvidia.com> --------- Signed-off-by: Jan Baczek <jbaczek@nvidia.com> Signed-off-by: yaoyu-33 <54727607+yaoyu-33@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: yaoyu-33 <54727607+yaoyu-33@users.noreply.github.com>
What does this PR do ?
Remove the need to load the yaml module inside GPT model and use hydra config instead.
Collection: nlp
Changelog
Usage
If you add to your main config:
then you can load the config from a known location like this:
++ tp_overlap@model.ub_tp_comm_overlap_cfg=<tp_config}
Before your PR is "Ready for review"
Pre checks:
PR Type:
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information