-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding server option to peft eval #7292
Conversation
Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com>
for more information, see https://pre-commit.ci
Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com>
…davidm/peft_server_gpt
from megatron.core import parallel_state | ||
|
||
HAVE_MEGATRON_CORE = True | ||
except: |
Check notice
Code scanning / CodeQL
Except block handles 'BaseException' Note
from megatron.core import parallel_state | ||
|
||
HAVE_MEGATRON_CORE = True | ||
except: |
Check notice
Code scanning / CodeQL
Empty except Note
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@@ -179,6 +192,44 @@ def main(cfg) -> None: | |||
|
|||
trainer.test(model) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we skip traininer.test
is cfg.server is used?
* Adding server to peft eval Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * updated trainer.test for server Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com> --------- Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Siddharth Tyagi <siddhartht@nvidia.com> Signed-off-by: Siddharth Tyagi <siddhartht@nvidia.com>
* Adding server to peft eval Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * updated trainer.test for server Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com> --------- Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: dorotat <dorotat@nvidia.com>
* Adding server to peft eval Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * updated trainer.test for server Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com> --------- Signed-off-by: David Mosallanezhad <dmosallanezh@nvidia.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
What does this PR do ?
Adding server options to GPT PEFT eval
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use this
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information