-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add text metrics to asr eval #8087
Conversation
Signed-off-by: stevehuang52 <heh@nvidia.com>
Signed-off-by: stevehuang52 <heh@nvidia.com>
…A/NeMo into add_text_metrics_evaluator
# if return_hypotheses: | ||
# # dump log probs per file | ||
# for idx in range(logits.shape[0]): | ||
# current_hypotheses[idx].y_sequence = logits[idx][: logits_len[idx]] |
Check notice
Code scanning / CodeQL
Commented-out code Note
jenkins |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nltk has issues on clusters, I'll send you a thread on slack later. Make the class with imports nltk run only inside of the place that's needed, not at the top of the file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nevermind above comment, nltk itself is fine, it was another library that was acting poorly by installing nltk stuff at import time.
Lgtm
jenkins |
* add text metrics to asr eval Signed-off-by: stevehuang52 <heh@nvidia.com> * temporary fix for EncDecTransfModelBPE Signed-off-by: stevehuang52 <heh@nvidia.com> --------- Signed-off-by: stevehuang52 <heh@nvidia.com> Signed-off-by: Piotr Żelasko <petezor@gmail.com>
* add text metrics to asr eval Signed-off-by: stevehuang52 <heh@nvidia.com> * temporary fix for EncDecTransfModelBPE Signed-off-by: stevehuang52 <heh@nvidia.com> --------- Signed-off-by: stevehuang52 <heh@nvidia.com> Signed-off-by: Sasha Meister <ameister@nvidia.com>
* add text metrics to asr eval Signed-off-by: stevehuang52 <heh@nvidia.com> * temporary fix for EncDecTransfModelBPE Signed-off-by: stevehuang52 <heh@nvidia.com> --------- Signed-off-by: stevehuang52 <heh@nvidia.com>
What does this PR do ?
Add some text metrics to ASR evaluator to support AST models