-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix AST eval #8112
Fix AST eval #8112
Conversation
Signed-off-by: stevehuang52 <heh@nvidia.com>
Signed-off-by: stevehuang52 <heh@nvidia.com>
…A/NeMo into add_text_metrics_evaluator
Signed-off-by: stevehuang52 <heh@nvidia.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks
jenkins |
jenkins |
) | ||
if gt_text_attr_name not in sample: | ||
if "text" in sample: | ||
gt_text_attr_name = "text" |
Check notice
Code scanning / CodeQL
Unused local variable Note
f"ground-truth text attribute {pred_text_attr_name} is not present in manifest! Cannot calculate {metric}. Returning!" | ||
) | ||
if "text" in sample: | ||
gt_text_attr_name = "text" |
Check notice
Code scanning / CodeQL
Unused local variable Note
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jenkins |
* add text metrics to asr eval Signed-off-by: stevehuang52 <heh@nvidia.com> * temporary fix for EncDecTransfModelBPE Signed-off-by: stevehuang52 <heh@nvidia.com> * fix bleu eval Signed-off-by: stevehuang52 <heh@nvidia.com> * fix typo Signed-off-by: stevehuang52 <heh@nvidia.com> --------- Signed-off-by: stevehuang52 <heh@nvidia.com> Co-authored-by: fayejf <36722593+fayejf@users.noreply.github.com>
* add text metrics to asr eval Signed-off-by: stevehuang52 <heh@nvidia.com> * temporary fix for EncDecTransfModelBPE Signed-off-by: stevehuang52 <heh@nvidia.com> * fix bleu eval Signed-off-by: stevehuang52 <heh@nvidia.com> * fix typo Signed-off-by: stevehuang52 <heh@nvidia.com> --------- Signed-off-by: stevehuang52 <heh@nvidia.com> Co-authored-by: fayejf <36722593+fayejf@users.noreply.github.com> Signed-off-by: Sasha Meister <ameister@nvidia.com>
* add text metrics to asr eval Signed-off-by: stevehuang52 <heh@nvidia.com> * temporary fix for EncDecTransfModelBPE Signed-off-by: stevehuang52 <heh@nvidia.com> * fix bleu eval Signed-off-by: stevehuang52 <heh@nvidia.com> * fix typo Signed-off-by: stevehuang52 <heh@nvidia.com> --------- Signed-off-by: stevehuang52 <heh@nvidia.com> Co-authored-by: fayejf <36722593+fayejf@users.noreply.github.com>
Fix bleu calculation for ASR evaluator