Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HF to .nemo for Mixtral-8x22B-instruct #9060

Merged
merged 6 commits into from
May 3, 2024

Conversation

akoumpa
Copy link
Member

@akoumpa akoumpa commented Apr 29, 2024

What does this PR do ?

Updates the HF to .nemo converter script to add support for Mixtral-8x22B-instruct.
In particular, the Mixtral-8x22B-instruct is identical to Mixtral-8x22B, except for the tokenizer.

This PR adds another step which converts the HF tokenizer to sentencepiece.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Jenkins CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

There's no need to comment jenkins on the PR to trigger Jenkins CI.
The GitHub Actions CI will run automatically when the PR is opened.
To run CI on an untrusted fork, a NeMo user with write access must click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

akoumpa and others added 5 commits April 26, 2024 02:26
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
@akoumpa akoumpa self-assigned this May 3, 2024
@akoumpa akoumpa marked this pull request as ready for review May 3, 2024 16:27
Copy link
Collaborator

@dimapihtar dimapihtar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@pablo-garay pablo-garay merged commit b4c5644 into main May 3, 2024
133 checks passed
@pablo-garay pablo-garay deleted the akoumparouli/mixtral_instruct_import branch May 3, 2024 18:53
rohitrango pushed a commit to rohitrango/NeMo that referenced this pull request Jun 25, 2024
* fixes

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

* Make sentencepiece model if souce ckpt does not include it

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

* limit --precision valid choises

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

* rename functions

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* remove unused var

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

---------

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants