Remove .nemo instead of renaming #9281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com>
|
Docstring needs to be updated but overall ok |
titu1994
previously approved these changes
May 22, 2024
Signed-off-by: dimapihtar <dpihtar@gmail.com>
This reverts commit b836410. Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com>
artbataev
reviewed
May 23, 2024
There was a problem hiding this comment.
Please also add checks for the behavior in tests (tests/core/test_exp_manager.py) to avoid such a bug in future, as suggested in #9232
def test_nemo_checkpoint_always_save_nemo(self, tmp_path):
...
assert len(list((tmp_path / "test/checkpoints").glob("default*.nemo"))) == 1 # check number of `.nemo` checkpointsSigned-off-by: Mikołaj Błaż <mblaz@nvidia.com>
Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com>
Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com>
…to mblaz/fix-duplicated-nemo
Signed-off-by: mikolajblaz <mikolajblaz@users.noreply.github.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -681,8 +705,7 @@ | |||
| """ | |||
| tmp_path = tmp_path / "test_3" | |||
|
|
|||
| class CustomLoop(_TrainingEpochLoop): | |||
| ... | |||
| class CustomLoop(_TrainingEpochLoop): ... | |||
Check notice
Code scanning / CodeQL
Statement has no effect Note test
|
added the test from repro: https://github.com/NVIDIA/NeMo/pull/9281/files#diff-b1e596fcfe12238f95a6145a309dfbcdcee6bd67f68505aa42f8865d759f377bR461 |
Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com>
|
@titu1994 CI on |
|
There are some issues with the CI, @pablo-garay can you take a look? @titu1994 I assume it needs to go to 2.0.0.rc as well? |
pablo-garay
approved these changes
May 23, 2024
pablo-garay
pushed a commit
that referenced
this pull request
May 23, 2024
* Remove .nemo instead of renaming Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * add ignore_errors=True flag Signed-off-by: dimapihtar <dpihtar@gmail.com> * Revert "Remove .nemo instead of renaming" This reverts commit b836410. Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * Remove backup .nemo after success Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * Update tests Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * Backup .nemo imediately before save_to Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * Apply isort and black reformatting Signed-off-by: mikolajblaz <mikolajblaz@users.noreply.github.com> * Fix CTC import Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> --------- Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> Signed-off-by: dimapihtar <dpihtar@gmail.com> Signed-off-by: mikolajblaz <mikolajblaz@users.noreply.github.com> Co-authored-by: dimapihtar <dpihtar@gmail.com>
|
Yup needs to be cherry picked into 2.0 as well |
BoxiangW
pushed a commit
to BoxiangW/NeMo
that referenced
this pull request
Jun 5, 2024
* Remove .nemo instead of renaming Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * add ignore_errors=True flag Signed-off-by: dimapihtar <dpihtar@gmail.com> * Revert "Remove .nemo instead of renaming" This reverts commit b836410. Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * Remove backup .nemo after success Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * Update tests Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * Backup .nemo imediately before save_to Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * Apply isort and black reformatting Signed-off-by: mikolajblaz <mikolajblaz@users.noreply.github.com> * Fix CTC import Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> --------- Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> Signed-off-by: dimapihtar <dpihtar@gmail.com> Signed-off-by: mikolajblaz <mikolajblaz@users.noreply.github.com> Co-authored-by: dimapihtar <dpihtar@gmail.com> Signed-off-by: Boxiang Wang <boxiangw@nvidia.com>
janekl
pushed a commit
that referenced
this pull request
Jun 12, 2024
* Remove .nemo instead of renaming Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * add ignore_errors=True flag Signed-off-by: dimapihtar <dpihtar@gmail.com> * Revert "Remove .nemo instead of renaming" This reverts commit b836410. Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * Remove backup .nemo after success Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * Update tests Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * Backup .nemo imediately before save_to Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * Apply isort and black reformatting Signed-off-by: mikolajblaz <mikolajblaz@users.noreply.github.com> * Fix CTC import Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> --------- Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> Signed-off-by: dimapihtar <dpihtar@gmail.com> Signed-off-by: mikolajblaz <mikolajblaz@users.noreply.github.com> Co-authored-by: dimapihtar <dpihtar@gmail.com> Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
rohitrango
pushed a commit
to rohitrango/NeMo
that referenced
this pull request
Jun 25, 2024
* Remove .nemo instead of renaming Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * add ignore_errors=True flag Signed-off-by: dimapihtar <dpihtar@gmail.com> * Revert "Remove .nemo instead of renaming" This reverts commit b836410. Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * Remove backup .nemo after success Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * Update tests Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * Backup .nemo imediately before save_to Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * Apply isort and black reformatting Signed-off-by: mikolajblaz <mikolajblaz@users.noreply.github.com> * Fix CTC import Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> --------- Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> Signed-off-by: dimapihtar <dpihtar@gmail.com> Signed-off-by: mikolajblaz <mikolajblaz@users.noreply.github.com> Co-authored-by: dimapihtar <dpihtar@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
This is a fix to #9015 which resulted in creating too many .nemo files.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information