-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move load state dict after initialize parallel state in nlp_model #9382
Conversation
Look good to me 👍 Can you apply a similar |
Signed-off-by: Ryan Li <rynli@amazon.com>
Signed-off-by: Ryan Li <rynli@amazon.com>
Done, thanks for review. |
Could you add the |
…IDIA#9382) * move load state dict after initialize parallel state Signed-off-by: Ryan Li <rynli@amazon.com> * delay sharded_state_dict in save_to Signed-off-by: Ryan Li <rynli@amazon.com> --------- Signed-off-by: Ryan Li <rynli@amazon.com> Co-authored-by: Ryan Li <rynli@amazon.com>
…IDIA#9382) * move load state dict after initialize parallel state Signed-off-by: Ryan Li <rynli@amazon.com> * delay sharded_state_dict in save_to Signed-off-by: Ryan Li <rynli@amazon.com> --------- Signed-off-by: Ryan Li <rynli@amazon.com> Co-authored-by: Ryan Li <rynli@amazon.com>
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Move loading sharded state dict after initialize parallel state.
Addresses #8460
Notes:
Collection: [Note which collection this PR will affect]
nlp/language_modeling
Changelog
Usage
For the nemo aligner SFT use case:
GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information