Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cherry pick of #9266 #9411

Merged
merged 29 commits into from
Jun 10, 2024
Merged

cherry pick of #9266 #9411

merged 29 commits into from
Jun 10, 2024

Conversation

dimapihtar
Copy link
Collaborator

What does this PR do ?

cherry pick of #9266 PR.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

dimapihtar and others added 24 commits June 7, 2024 03:48
@dimapihtar
add deprecation warnings for non-mcore models
93cedad 
Signed-off-by: dimapihtar <dpihtar@gmail.com>
@pre-commit-ci @dimapihtar
[pre-commit.ci] auto fixes from pre-commit.com hooks
db0148b 
for more information, see https://pre-commit.ci
@dimapihtar
change warning default time
26fc6c5 
Signed-off-by: dimapihtar <dpihtar@gmail.com>
@dimapihtar
remove unused import
e317c98 
Signed-off-by: dimapihtar <dpihtar@gmail.com>
@dimapihtar
Apply isort and black reformatting
1687f4d 
Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com>
@dimapihtar
remove deprecated tests
7840c34 
Signed-off-by: dimapihtar <dpihtar@gmail.com>
@dimapihtar
set mcore_gpt to True
4a35d54 
Signed-off-by: dimapihtar <dpihtar@gmail.com>
@dimapihtar
set mcore_bert to True
8729470 
Signed-off-by: dimapihtar <dpihtar@gmail.com>
@dimapihtar
remove deprecated tests
7e881f3 
Signed-off-by: dimapihtar <dpihtar@gmail.com>
@dimapihtar
remove deprecated unit tests
28ee1df 
Signed-off-by: dimapihtar <dpihtar@gmail.com>
@dimapihtar
add deprecation warning
e294e32 
Signed-off-by: dimapihtar <dpihtar@gmail.com>
@dimapihtar
Apply isort and black reformatting
140b464 
Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com>
@dimapihtar
remove deprecated playbook
6510d32 
Signed-off-by: dimapihtar <dpihtar@gmail.com>
@dimapihtar
remove deprecated tutorial
d057a9c 
Signed-off-by: dimapihtar <dpihtar@gmail.com>
@dimapihtar
turn off FA for Bert
1964d60 
Signed-off-by: dimapihtar <dpihtar@gmail.com>
@dimapihtar
turn of FA for Bert
e0e3add 
Signed-off-by: dimapihtar <dpihtar@gmail.com>
@dimapihtar
change mcore commit
0a54b6f 
Signed-off-by: dimapihtar <dpihtar@gmail.com>
@pablo-garay @dimapihtar
adjustments
fc38067
@dimapihtar
update TE commit
79c61dc 
Signed-off-by: dimapihtar <dpihtar@gmail.com>
@dimapihtar
fix mcore precision issue
965df31 
Signed-off-by: dimapihtar <dpihtar@gmail.com>
@dimapihtar
change precision for bert
1e7a4b4 
Signed-off-by: dimapihtar <dpihtar@gmail.com>
@dimapihtar
change precision for fine-tuning
928b717 
Signed-off-by: dimapihtar <dpihtar@gmail.com>
@dimapihtar
turn off fused attention for bert
0702d47 
Signed-off-by: dimapihtar <dpihtar@gmail.com>
@dimapihtar
fix bert test
9d41fbd 
Signed-off-by: dimapihtar <dpihtar@gmail.com>
@dimapihtar
fix typo
6f77b18 
Signed-off-by: dimapihtar <dpihtar@gmail.com>
@dimapihtar
remove unnecessary
1a9df1b 
Signed-off-by: dimapihtar <dpihtar@gmail.com>
ericharper
ericharper approved these changes Jun 10, 2024
View reviewed changes
Copy link
Collaborator

@ericharper ericharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@ericharper ericharper merged commit 27de845 into main Jun 10, 2024
112 checks passed
@ericharper ericharper deleted the dpykhtar/deprecate_non_mcore_cherry_pick branch June 10, 2024 22:02
janekl pushed a commit that referenced this pull request Jun 12, 2024
@dimapihtar @pre-commit-ci
@pablo-garay @janekl
cherry pick of #9266 (#9411)
937ba6d 
* add deprecation warnings for non-mcore models

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* change warning default time

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* remove unused import

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com>

* remove deprecated tests

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* set mcore_gpt to True

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* set mcore_bert to True

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* remove deprecated tests

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* remove deprecated unit tests

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* add deprecation warning

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com>

* remove deprecated playbook

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* remove deprecated tutorial

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* turn off FA for Bert

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* turn of FA for Bert

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* change mcore commit

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* adjustments

* update TE commit

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* fix mcore precision issue

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* change precision for bert

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* change precision for fine-tuning

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* turn off fused attention for bert

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* fix bert test

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* revert tests

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* fix typo

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* remove unnecessary

Signed-off-by: dimapihtar <dpihtar@gmail.com>

---------

Signed-off-by: dimapihtar <dpihtar@gmail.com>
Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: dimapihtar <dimapihtar@users.noreply.github.com>
Co-authored-by: Pablo Garay <pagaray@nvidia.com>
Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
galv pushed a commit to galv/NeMo that referenced this pull request Jun 13, 2024
@dimapihtar @pre-commit-ci
@pablo-garay @galv
cherry pick of NVIDIA#9266 (NVIDIA#9411)
9359a55 
* add deprecation warnings for non-mcore models

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* change warning default time

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* remove unused import

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com>

* remove deprecated tests

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* set mcore_gpt to True

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* set mcore_bert to True

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* remove deprecated tests

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* remove deprecated unit tests

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* add deprecation warning

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com>

* remove deprecated playbook

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* remove deprecated tutorial

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* turn off FA for Bert

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* turn of FA for Bert

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* change mcore commit

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* adjustments

* update TE commit

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* fix mcore precision issue

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* change precision for bert

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* change precision for fine-tuning

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* turn off fused attention for bert

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* fix bert test

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* revert tests

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* fix typo

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* remove unnecessary

Signed-off-by: dimapihtar <dpihtar@gmail.com>

---------

Signed-off-by: dimapihtar <dpihtar@gmail.com>
Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: dimapihtar <dimapihtar@users.noreply.github.com>
Co-authored-by: Pablo Garay <pagaray@nvidia.com>
JesusPaz pushed a commit to JesusPaz/NeMo that referenced this pull request Jun 18, 2024
@dimapihtar @pre-commit-ci
@pablo-garay @JesusPaz
cherry pick of NVIDIA#9266 (NVIDIA#9411)
839beac 
* add deprecation warnings for non-mcore models

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* change warning default time

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* remove unused import

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com>

* remove deprecated tests

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* set mcore_gpt to True

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* set mcore_bert to True

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* remove deprecated tests

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* remove deprecated unit tests

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* add deprecation warning

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com>

* remove deprecated playbook

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* remove deprecated tutorial

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* turn off FA for Bert

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* turn of FA for Bert

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* change mcore commit

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* adjustments

* update TE commit

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* fix mcore precision issue

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* change precision for bert

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* change precision for fine-tuning

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* turn off fused attention for bert

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* fix bert test

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* revert tests

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* fix typo

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* remove unnecessary

Signed-off-by: dimapihtar <dpihtar@gmail.com>

---------

Signed-off-by: dimapihtar <dpihtar@gmail.com>
Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: dimapihtar <dimapihtar@users.noreply.github.com>
Co-authored-by: Pablo Garay <pagaray@nvidia.com>
rohitrango pushed a commit to rohitrango/NeMo that referenced this pull request Jun 25, 2024
@dimapihtar @pre-commit-ci @pablo-garay
cherry pick of NVIDIA#9266 (NVIDIA#9411)
8788ad1 
* add deprecation warnings for non-mcore models

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* change warning default time

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* remove unused import

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com>

* remove deprecated tests

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* set mcore_gpt to True

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* set mcore_bert to True

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* remove deprecated tests

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* remove deprecated unit tests

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* add deprecation warning

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* Apply isort and black reformatting

Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com>

* remove deprecated playbook

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* remove deprecated tutorial

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* turn off FA for Bert

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* turn of FA for Bert

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* change mcore commit

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* adjustments

* update TE commit

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* fix mcore precision issue

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* change precision for bert

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* change precision for fine-tuning

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* turn off fused attention for bert

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* fix bert test

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* revert tests

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* fix typo

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* remove unnecessary

Signed-off-by: dimapihtar <dpihtar@gmail.com>

---------

Signed-off-by: dimapihtar <dpihtar@gmail.com>
Signed-off-by: dimapihtar <dimapihtar@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: dimapihtar <dimapihtar@users.noreply.github.com>
Co-authored-by: Pablo Garay <pagaray@nvidia.com>
@ko3n1g ko3n1g mentioned this pull request Jul 18, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericharper ericharper ericharper approved these changes

Assignees
No one assigned
Labels
CI NLP Run CICD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dimapihtar @ericharper @pablo-garay