Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Document that cub's device scan supports inplace operations, and add tests to enforce this feature. #301

Merged
merged 3 commits into from
May 20, 2021

Conversation

zasdfgbnm
Copy link
Contributor

Per the title. PyTorch is already using this assumption, and it seems to be working fine. But we want the support of this feature to be official.

cc: @ngimel

Copy link
Collaborator

@alliepiper alliepiper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch!

This LGTM aside from one small style issue with template parameter naming. I'll start running tests once this change has been made.

test/test_device_scan.cu Outdated Show resolved Hide resolved
@alliepiper alliepiper added the helps: pytorch Helps or needed by PyTorch. label May 11, 2021
@alliepiper alliepiper added this to the 1.13.0 milestone May 11, 2021
@alliepiper alliepiper self-requested a review May 12, 2021 15:59
@alliepiper alliepiper added the only: gpuci Changes to gpuCI only. Doesn't need internal NVIDIA CI. label May 12, 2021
alliepiper added a commit to alliepiper/thrust that referenced this pull request May 12, 2021
@alliepiper
Copy link
Collaborator

gpuCI testing branch: NVIDIA/thrust#1433

@alliepiper alliepiper added the testing: gpuCI in progress Started gpuCI testing. label May 12, 2021
@alliepiper alliepiper added testing: gpuCI passed Passed gpuCI testing. and removed testing: gpuCI in progress Started gpuCI testing. labels May 20, 2021
@alliepiper alliepiper merged commit ad5299d into NVIDIA:main May 20, 2021
@zasdfgbnm zasdfgbnm deleted the scan-inplace branch May 20, 2021 21:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
helps: pytorch Helps or needed by PyTorch. only: gpuci Changes to gpuCI only. Doesn't need internal NVIDIA CI. testing: gpuCI passed Passed gpuCI testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants