This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Update histogram documentation. #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alliepiper
added
the
only: docs
|
@senior-zero This needs a review when you get a chance. |
gevtushenko
approved these changes
Jul 28, 2021
| @@ -178,9 +178,9 @@ struct DeviceHistogram | |||
| * int num_row_samples; // e.g., 5 | |||
| * int num_rows; // e.g., 2; | |||
| * size_t row_stride_bytes; // e.g., 7 * sizeof(float) | |||
| * float* d_samples; // e.g., [2.2, 6.0, 7.1, 2.9, 3.5, -, -, | |||
| * // 0.3, 2.9, 2.0, 6.1, 999.5, -, -] | |||
| * int* d_histogram; // e.g., [ -, -, -, -, -, -, -, -] | |||
There was a problem hiding this comment.
It seems that the same fix is required for two overloads of HistogramRange.
There was a problem hiding this comment.
Oops, I thought I'd checked the other examples. I'll update this before merging.
- Remove extra values from `d_histogram` result. - Update input samples to avoid fp values that are the same as a computed level. These introduce ambiguity into the result due to fp rounding/math.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove extra values from
d_histogramresult.Update input samples to avoid fp values that are the same as
a computed level. These introduce ambiguity into the result due
to fp rounding/math.
cc: @cliffburdick