Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Add scan by key algorithms to cub #376

Merged
merged 1 commit into from
Oct 19, 2021
Merged

Add scan by key algorithms to cub #376

merged 1 commit into from
Oct 19, 2021

Conversation

zasdfgbnm
Copy link
Contributor

No description provided.

@zasdfgbnm zasdfgbnm changed the title [WIP] Add scan by key algorithms to cub Add scan by key algorithms to cub Sep 23, 2021
@zasdfgbnm zasdfgbnm marked this pull request as ready for review September 23, 2021 20:37
@zasdfgbnm
Copy link
Contributor Author

@allisonvacanti @senior-zero This PR is mostly ready. I haven't added docs yet, I will update this PR later for docs. This PR does not support my request #294, I will add the support for it in a separate PR after both this and #305 are merged.

@alliepiper alliepiper self-assigned this Sep 30, 2021
@alliepiper alliepiper self-requested a review September 30, 2021 18:57
@alliepiper alliepiper added this to the 1.15.0 milestone Sep 30, 2021
@zasdfgbnm
Copy link
Contributor Author

docs added

@zasdfgbnm zasdfgbnm mentioned this pull request Oct 6, 2021
Closed
This was referenced Oct 13, 2021
Closed
Closed
@alliepiper alliepiper added helps: pytorch Helps or needed by PyTorch. P1: should have Necessary, but not critical. labels Oct 14, 2021
alliepiper
alliepiper suggested changes Oct 15, 2021
View reviewed changes
Copy link
Collaborator

@alliepiper alliepiper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pointed out a few minor issues that we should address before merging, but otherwise I think we can get this in for 1.15 if the tests pass. I plan to make the 1.15 RC early next week.

I'll start CI on the current version since the suggested changes shouldn't affect anything significant.

cub/device/dispatch/dispatch_scan_by_key.cuh Outdated Show resolved Hide resolved
cub/device/dispatch/dispatch_scan_by_key.cuh Outdated Show resolved Hide resolved
cub/device/dispatch/dispatch_scan_by_key.cuh Outdated Show resolved Hide resolved
cub/device/dispatch/dispatch_scan_by_key.cuh Outdated Show resolved Hide resolved
@alliepiper alliepiper assigned zasdfgbnm and unassigned alliepiper Oct 15, 2021
alliepiper added a commit to alliepiper/thrust that referenced this pull request Oct 15, 2021
@alliepiper
Do not commit; Testing NVIDIA/cub#376.
837577d
alliepiper added a commit to alliepiper/thrust that referenced this pull request Oct 15, 2021
@alliepiper
Do not commit; Testing NVIDIA/cub#376.
1ec0475
@alliepiper
Copy link
Collaborator

DVS CL: 30538159
gpuCI: NVIDIA/thrust#1538

@alliepiper alliepiper added testing: gpuCI in progress Started gpuCI testing. testing: internal ci in progress Currently testing on internal NVIDIA CI (DVS). labels Oct 15, 2021
@alliepiper
Copy link
Collaborator

It looks like there are some build issues in the early results on gpuCI that will also need to be addressed.

@zasdfgbnm
Copy link
Contributor Author

I think the failure is because I need to rebase this branch after NVIDIA/thrust#1519 being merged into thrust. I have rebased this PR and resolved reviews, hopefully, this will pass now.

@zasdfgbnm zasdfgbnm force-pushed the scan-by-key branch 2 times, most recently from 0c4a79e to 3ac18f7 Compare October 17, 2021 17:12
alliepiper added a commit to alliepiper/thrust that referenced this pull request Oct 18, 2021
@alliepiper
Do not commit; Testing NVIDIA/cub#376.
5f495ab
@alliepiper
Copy link
Collaborator

Thanks -- restarted tests:

DVS CL: 30544689
gpuCI: NVIDIA/thrust#1538

@alliepiper alliepiper assigned alliepiper and unassigned zasdfgbnm Oct 18, 2021
@alliepiper alliepiper added testing: internal ci passed Passed internal NVIDIA CI (DVS). testing: gpuCI passed Passed gpuCI testing. and removed testing: internal ci in progress Currently testing on internal NVIDIA CI (DVS). testing: internal ci passed Passed internal NVIDIA CI (DVS). testing: gpuCI in progress Started gpuCI testing. labels Oct 18, 2021
@alliepiper alliepiper merged commit b94fc77 into NVIDIA:main Oct 19, 2021
@alliepiper
Copy link
Collaborator

All set -- this will make it into 1.15.

@zasdfgbnm zasdfgbnm deleted the scan-by-key branch October 19, 2021 16:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alliepiper alliepiper alliepiper approved these changes

Assignees

@alliepiper alliepiper

Labels
helps: pytorch Helps or needed by PyTorch. P1: should have Necessary, but not critical. testing: gpuCI passed Passed gpuCI testing. testing: internal ci passed Passed internal NVIDIA CI (DVS).
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.
2 participants
@zasdfgbnm @alliepiper