Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the no-source bug in gdrdrv-dkms.deb (issue #131) #133

Merged
merged 8 commits into from
Aug 13, 2020

Conversation

pakmarkthub
Copy link
Collaborator

@pakmarkthub pakmarkthub commented Aug 11, 2020

Problems:

This PR:

Pre-submit testing:

  • On Ubuntu18.04.
  • Tested install and purge for both gdrcopy.deb and gdrdrv-dkms.deb.
  • Tested upgrade gdrdrv-dkms from version 2.0 to 2.1.

Copy link
Member

@drossetti drossetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while we are here, I also suggest to rename the dkms to include the gdrcopy_ prefix, and update metadata so that the new package supersedes the old one

UPDATE: actually filed a new issue and let's work on that there

packages/build-deb-packages.sh Show resolved Hide resolved
packages/build-deb-packages.sh Show resolved Hide resolved
@pakmarkthub
Copy link
Collaborator Author

@drossetti

This should fix as you suggested. Please re-review.

By the way, since you plan to create a different PR, I didn't add gdrcopy_ prefix to gdrdrv-dkms.deb here.

@pakmarkthub pakmarkthub changed the title Fixed issue 131 Fix issue 131 Aug 12, 2020
@pakmarkthub pakmarkthub changed the title Fix issue 131 Fix the no-source bug in gdrdrv-dkms.deb (issue #131) Aug 12, 2020
Copy link
Member

@drossetti drossetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! it looks good, small change if anything

packages/build-deb-packages.sh Show resolved Hide resolved
@drossetti
Copy link
Member

By the way, since you plan to create a different PR, I didn't add gdrcopy_ prefix to gdrdrv-dkms.deb here.

it makes sense!

@drossetti drossetti merged commit 36e7db5 into NVIDIA:master Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants