Fix collect_set on struct type #4996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
build |
|
I saw #4992 is targeted to release 22.04. |
The branch-22.06 has not been created yet. |
abellina
reviewed
Mar 21, 2022
|
Overall LGTM, just had one question on a test. |
revans2
approved these changes
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the development of collect-like reduction aggregation #4992, I found that
CudfCollectSetandCudfMergeSetsapply wrongNullEquality, which should beNullEquality.EQUAL. This problem only affects struct types because collect ops applyNullPolicy.EXCLUDE, which means null entries will be excluded during the collection. However, with struct type, nulls wrapped inside outer-level struct will trigger the NullEquality problem.Since #4992 is targetted to release 22.06 , I create a separate PR to fix this problem.
Signed-off-by: sperlingxx lovedreamf@gmail.com