Update csv float tests to reflect changes in precision in cuDF #5230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andy Grove <andygrove@nvidia.com>
|
build |
jlowe
approved these changes
Apr 13, 2022
sameerz
added
the
task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andy Grove andygrove@nvidia.com
Closes #5211
This PR removes one test value that was overflowing to
Infas a result of a recent change in precision in cuDF. It also adds exact tests for reading small floating-point values from CSV.We already have documentation explaining that numbers in certain ranges, such as
1.7976931348623158E308 <= x < 1.7976931348623159E308will have different behavior between CPU and GPU and the number removed from the test (1.7976931348623158E308) was within this range so I don't think any documentation update is required.