Update nightly build and deploy script for arm artifacts [skip ci] #9888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peixin Li <pxli@nyu.edu>
pxLi
requested review from
jlowe,
revans2,
tgravescs,
GaryShen2008 and
NvTimLiu
as code owners
jlowe
reviewed
Nov 29, 2023
jenkins/deploy.sh
Outdated
| @@ -48,6 +49,7 @@ ART_GROUP_ID=$(mvnEval $DIST_PL project.groupId) | |||
| ART_VER=$(mvnEval $DIST_PL project.version) | |||
| DEFAULT_CUDA_CLASSIFIER=$(mvnEval $DIST_PL cuda.version) | |||
| CUDA_CLASSIFIERS=${CUDA_CLASSIFIERS:-"$DEFAULT_CUDA_CLASSIFIER"} | |||
| CLASSIFIERS==${CLASSIFIERS:-"$CUDA_CLASSIFIERS"} # default as CUDA_CLASSIFIERS for compatibility | |||
There was a problem hiding this comment.
Suggested change
| CLASSIFIERS==${CLASSIFIERS:-"$CUDA_CLASSIFIERS"} # default as CUDA_CLASSIFIERS for compatibility | |
| CLASSIFIERS=${CLASSIFIERS:-"$CUDA_CLASSIFIERS"} # default as CUDA_CLASSIFIERS for compatibility |
There was a problem hiding this comment.
nice catch! forget to append test change to commit, thanks
|
build |
jlowe
approved these changes
Nov 30, 2023
|
I am going to merge this one and will keep monitoring status of nightly runs. If needed, I will post some followups thanks |
ttnghia
added a commit
to ttnghia/spark-rapids
that referenced
this pull request
Dec 1, 2023
…p ci] (NVIDIA#9888)" This reverts commit b92a0b4.
ttnghia
added a commit
to ttnghia/spark-rapids
that referenced
this pull request
Dec 1, 2023
…cts [skip ci] (NVIDIA#9888)"" This reverts commit 5d31719.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #9274 #6881
Some updates:
CLASSIFIERSto replaceCUDA_CLASSIFIERSCUDA_CLASSIFIERSfor compatibility (so merging this would not affect the current build process)-Tto speed up mvn build if skipTests=trueThis has been verified internally, [skip ci] as the change would not be covered in pre-merge
I will update internal pipelines after merging this