Minification and more! #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The block inside `if (proxy == 'uv' || 'osana')` is always going to run, because 'osana' is a truthy value. I hope those aren't bad habits from Python.
Unlike node-static, serve-static sets the proper encoding. Also, it's used by Express. :^)
Now that the static file server is sane in terms of encoding, this new production bundle can be used, even with all of its janky regexes.
Prior to this commit, Osana was not minified at all. This commit updates Osana so it is minified. Refraining from minification is just asking for longer load times.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should have been a simple PR to test if my SSH signatures worked. Instead, I got yakbaited into minifying Osana and UV.
Enjoy!