Implement engine_exchangeCapabilities method
#5212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubo
force-pushed
the
feature/engine_getcapabilities
branch
from
aec4e8b
to
c20eaa7
Compare
rubo
requested review from
LukaszRozmej and
MarekM25
and removed request for
LukaszRozmej
MarekM25
reviewed
Jan 26, 2023
Take a closer look. |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
MarekM25
approved these changes
Jan 26, 2023
rubo
changed the title
engine_getCapabilities methodengine_exchangeCapabilities method
MarekM25
requested changes
Jan 26, 2023
rubo
force-pushed
the
feature/engine_getcapabilities
branch
from
b459446
to
d0e0f01
Compare
MarekM25
reviewed
Jan 26, 2023
src/Nethermind/Nethermind.Merge.Plugin.Test/EngineModuleTests.V1.cs
Outdated
Show resolved
Hide resolved
MarekM25
requested changes
Jan 26, 2023
|
|
||
| public IBlockProcessingQueue BlockProcessingQueue { get; set; } = null!; | ||
| public IBlockTree BlockTree { get; set; } = null!; | ||
|
|
There was a problem hiding this comment.
What was changed in TestBlockchain?
There was a problem hiding this comment.
Added mutator for LogManager, line 260.
MarekM25
approved these changes
Jan 27, 2023
| { | ||
| watch.Stop(); | ||
|
|
||
| Metrics.ForkchoiceUpdedExecutionTime = watch.ElapsedMilliseconds; |
There was a problem hiding this comment.
You are changing the metrics, please remove
| _capabilities[nameof(IEngineRpcModule.engine_exchangeTransitionConfigurationV1)] = true; | ||
| _capabilities[nameof(IEngineRpcModule.engine_executionStatus)] = true; | ||
| _capabilities[nameof(IEngineRpcModule.engine_forkchoiceUpdatedV1)] = true; | ||
| _capabilities[nameof(IEngineRpcModule.engine_forkchoiceUpdatedV2)] = spec.WithdrawalsEnabled; |
There was a problem hiding this comment.
don't you think that some list of the methods will be better?
rubo
force-pushed
the
feature/engine_getcapabilities
branch
from
c3353a5
to
dcc4d73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
engine_exchangeCapabilitiesmethod as specified in the specTypes of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?