Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodejs: Fix build on RISC-V #212315

Merged
merged 1 commit into from
Jan 24, 2023
Merged

nodejs: Fix build on RISC-V #212315

merged 1 commit into from
Jan 24, 2023

Conversation

zhaofengli
Copy link
Member

Description of changes

Fixes error:

ar: /build/node-v18.13.0/out/Release/obj.host/v8_base_without_compiler/deps/v8/src/heap/base/asm/riscv/push_registers_asm.o: No such file or directory

Haven't tried 19.x yet, but the fix seems to be already there.

Ref: #101651

Things done
  • Built on platform(s)
    • x86_64-linux (on master)
    • riscv64-linux (on master)
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Copy link
Member

@NickCao NickCao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed this fixing build on riscv64-linux.

@NickCao
Copy link
Member

NickCao commented Jan 24, 2023

Also 19.x builds without the patch.

@NickCao NickCao merged commit 5485410 into NixOS:staging Jan 24, 2023
@zhaofengli zhaofengli deleted the nodejs-riscv64 branch January 24, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants