Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

intel-one-mono: 1.2.0 -> 1.2.1 #237504

Merged
merged 1 commit into from
Jun 13, 2023
Merged

intel-one-mono: 1.2.0 -> 1.2.1 #237504

merged 1 commit into from
Jun 13, 2023

Conversation

oluceps
Copy link
Member

@oluceps oluceps commented Jun 13, 2023

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from simoneruffini June 13, 2023 08:16
drupol
drupol reviewed Jun 13, 2023
View reviewed changes
Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

Thanks for your PR!

I added non-blocking comments, it would be super nice if you could implement them.
Regardless of your decision, I'll merge this PR at some point anyway.

Thanks in advance!

pkgs/data/fonts/intel-one-mono/default.nix Outdated Show resolved Hide resolved
pkgs/data/fonts/intel-one-mono/default.nix Outdated Show resolved Hide resolved
pkgs/data/fonts/intel-one-mono/default.nix Outdated Show resolved Hide resolved
@drupol
Copy link
Contributor

drupol commented Jun 13, 2023

There's a minor editorconfig issue and it's good to go.

@oluceps @drupol
intel-one-mono: 1.2.0 -> 1.2.1
30dbe21 
Co-authored-by: drupol <pol.dellaiera@protonmail.com>
@drupol drupol merged commit 4894502 into NixOS:master Jun 13, 2023
@oluceps oluceps deleted the one-mono-up branch June 13, 2023 10:53
@drupol
Copy link
Contributor

drupol commented Jun 13, 2023

Thank you very much for fixing everything !

@github-actions github-actions bot mentioned this pull request Jul 28, 2023
Merged
1 task
@github-actions
Copy link
Contributor

Successfully created backport PR for release-23.05:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drupol drupol drupol approved these changes

@simoneruffini simoneruffini Awaiting requested review from simoneruffini

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oluceps @drupol @Kranzes