ntopng: fix missing static assets #238162
Conversation
|
Your PR message explains the situation better than the commit message. Copy it? |
Instead of building the `dist` make target in the derivation (requires npm and all that), we're using the upstream pre-built static assets. Upstream refers to these using a sub-module so we need to fetch that. Without this patch the web UI loads the html, but 404s on all CSS and JS assets because the `$out/share/ntopng/httpdocs/dist` directory is empty
samhug
force-pushed
the
ntopng-missing-assets
branch
from
0ce8cb0
to
25a5086
Compare
I've updated the commit message to match the PR
Unsure what the missing bits are unless this was referring to the commit message also. Fetching sub-modules and then updating the source hash to match was really the only change needed. |
Thanks!
Ok, thanks for clearing that up. (Note to self: it's a bad idea to look at PRs on phone.) |
|
Thanks for reviewing the PR! |
|
Successfully created backport PR for |
|
Git push to origin failed for release-23.05 with exitcode 1 |
Instead of building the
distmake target in the derivation (requires npm and all that), we're using the upstream pre-built static assets. Upstream refers to these using a sub-module so we need to fetch that.Without this patch the web UI loads the html, but 404s on all CSS and JS assets because the
$out/share/ntopng/httpdocs/distdirectory is emptyDescription of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)