Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sexp: init at 0.8.6 #239889

Merged
merged 1 commit into from
Jun 28, 2023
Merged

sexp: init at 0.8.6 #239889

merged 1 commit into from
Jun 28, 2023

Conversation

ribose-jeffreylau
Copy link
Contributor

Description of changes

https://github.com/rnpgp/sexp

C++ Library for SEXP (S-expressions)

This is a dependency of the next version of rnp.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ribose-jeffreylau
Copy link
Contributor Author

Result of nixpkgs-review pr 239889 run on aarch64-darwin 1

1 package built:
  • sexp

Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I made non-blocking comment, it would be super nice if you could implement them.

pkgs/development/libraries/sexp/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/sexp/default.nix Outdated Show resolved Hide resolved
@ribose-jeffreylau
Copy link
Contributor Author

Result of nixpkgs-review pr 239889 run on aarch64-darwin 1

1 package built:
  • sexp

@drupol drupol merged commit 38c223f into NixOS:master Jun 28, 2023
@github-actions
Copy link
Contributor

Successfully created backport PR for release-22.11:

@github-actions
Copy link
Contributor

Successfully created backport PR for release-23.05:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants