Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.simple-term-menu: init at 1.6.4 #274960

Merged
merged 2 commits into from
Dec 29, 2023

Conversation

syedmoizurrehman
Copy link
Contributor

Description of changes

Add Python package simple-term-menu.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@syedmoizurrehman
Copy link
Contributor Author

I have tested this change by importing my local nixpkgs and using the simple-term-menu package. I don't see any unit tests in the upstream so, I have left nativeCheckInputs empty. Please let me know if this needs to be populated.

@dansbandit
Copy link
Contributor

Result of nixpkgs-review pr 274960 run on x86_64-darwin 1

4 packages built:
  • python310Packages.simple-term-menu
  • python310Packages.simple-term-menu.dist
  • python311Packages.simple-term-menu
  • python311Packages.simple-term-menu.dist

@kirillrdy
Copy link
Member

@GrahamcOfBorg build python310Packages.simple-term-menu python311Packages.simple-term-menu

Copy link
Member

@natsukium natsukium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution! Welcome to nixpkgs!🎉

@natsukium natsukium merged commit 1f7530f into NixOS:master Dec 29, 2023
29 of 30 checks passed
@syedmoizurrehman
Copy link
Contributor Author

@natsukium Thank you, I appreciate you and @kirillrdy taking the time to review the changes!

@natsukium
Copy link
Member

Feel free to ping us if you would like a PR review or have any problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants