python311Packages.betterproto: disable failing pydantic tests #281994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Result of 9 packages built:
|
|
Result of 8 packages built:
|
nikstur
reviewed
Jan 19, 2024
| @@ -63,13 +70,14 @@ buildPythonPackage rec { | |||
| ''; | |||
|
|
|||
| meta = with lib; { | |||
| description = "Clean, modern, Python 3.6+ code generator & library for Protobuf 3 and async gRPC"; | |||
| description = "Code generator & library for Protobuf 3 and async gRPC"; | |||
There was a problem hiding this comment.
This is the upstream description. Not sure why we would want to change that.
There was a problem hiding this comment.
The "marketing part" or "how upstream thinks the project looks like" usually doesn't really add a lot of value to the description. If the library is modern and clean then we would not need to disable tests 😉
Sure, this change is highly opinionated.
13 tasks
All those builds are failing at the moment and are connected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Fix build (https://hydra.nixos.org/build/246526205)
See #269633
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.