Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vimPlugins.avante-nvim: Init at 2024-09-15 #339921

Merged
merged 3 commits into from
Sep 16, 2024
Merged

vimPlugins.avante-nvim: Init at 2024-09-15 #339921

merged 3 commits into from
Sep 16, 2024
+1,733 −0

Conversation

ttrei
Copy link
Contributor

@ttrei ttrei commented Sep 5, 2024 •
edited
Loading

Description of changes

New package: https://github.com/yetone/avante.nvim
Neovim plugin designed to emulate the behaviour of the Cursor AI IDE.

Requested here: #339382

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ttrei ttrei requested a review from figsoda as a code owner September 5, 2024 22:07
@ttrei ttrei marked this pull request as draft September 8, 2024 09:00
@ttrei
Copy link
Contributor Author

ttrei commented Sep 8, 2024

0.0.2 seems broken, claude sonnet always complains about missing context.

@ttrei ttrei mentioned this pull request Sep 8, 2024
Closed
aarnphm
aarnphm reviewed Sep 8, 2024
View reviewed changes
pkgs/applications/editors/vim/plugins/avante-nvim/default.nix Outdated
# The plugin expects the dynamic libraries to be under build/
postInstall = ''
mkdir -p $out/build
ln -s ${avante-lib}/*.so $out/build
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of ln I think you can just copy instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a downside to using symlinks here?
I used them to avoid duplicating the *.so files in nix store, and I saw that quite a lot of other plugins also use symlinks.

@vinnymeller
Copy link
Contributor

don't have any extra feedback on the diff but this is working perfectly for me so far 👍 thanks!

vinnymeller
vinnymeller suggested changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@vinnymeller vinnymeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments show changes needed to build + work properly on macos

Commit from my fork for reference in case I typod something here: bd270a4

pkgs/applications/editors/vim/plugins/avante-nvim/default.nix Show resolved Hide resolved
pkgs/applications/editors/vim/plugins/avante-nvim/default.nix Show resolved Hide resolved
pkgs/applications/editors/vim/plugins/avante-nvim/default.nix Outdated Show resolved Hide resolved
pkgs/applications/editors/vim/plugins/avante-nvim/default.nix Outdated Show resolved Hide resolved
pkgs/applications/editors/vim/plugins/overrides.nix Show resolved Hide resolved
@ttrei
Copy link
Contributor Author

ttrei commented Sep 9, 2024

@vinnymeller, thanks!
I incorporated your diff with a small change. Please verify that it works for you.

@ttrei ttrei marked this pull request as ready for review September 9, 2024 08:35
@ttrei ttrei changed the title vimPlugins.avante-nvim: Init at 0.0.2 vimPlugins.avante-nvim: Init at 2024-09-08 Sep 9, 2024
@vinnymeller
Copy link
Contributor

seems to be working fine 🙂

vinnymeller
vinnymeller approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@vinnymeller vinnymeller left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good from my pov

i imagine they'll want the commits squashed though

@ttrei
Copy link
Contributor Author

ttrei commented Sep 9, 2024

squashed and rebased onto latest master.

caarlos0 added a commit to caarlos0/dotfiles that referenced this pull request Sep 9, 2024
@caarlos0
feat(nvim): update avante-nvim
4705dac 
based on NixOS/nixpkgs#339921
@caarlos0
Copy link
Member

caarlos0 commented Sep 9, 2024

just tried this, seems to work!

PS: I think img-clip can be removed... avante only complains about it not being there once and then just work normally

@ttrei
Copy link
Contributor Author

ttrei commented Sep 9, 2024

PS: I think img-clip can be removed... avante only complains about it not being there once and then just work normally

yeah, i was wrong, it really is optional. i just had require('img-clip').setup ({}) in my config 🙄

@ttrei ttrei force-pushed the avante-nvim branch 2 times, most recently from ca1d7c6 to 4b50a8e Compare September 15, 2024 21:28
@ttrei ttrei mentioned this pull request Sep 16, 2024
Merged
13 tasks
@ofborg ofborg bot requested a review from aarnphm September 16, 2024 10:59
@GaetanLepage
Copy link
Contributor

Result of nixpkgs-review pr 339921 run on x86_64-linux 1

2 packages built:
  • vimPlugins.avante-nvim
  • vimPluginsUpdater

GaetanLepage
GaetanLepage approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Thanks @ttrei

@GaetanLepage
Copy link
Contributor

Result of nixpkgs-review pr 339921 run on aarch64-darwin 1

2 packages built:
  • vimPlugins.avante-nvim
  • vimPluginsUpdater

@GaetanLepage
Copy link
Contributor

Result of nixpkgs-review pr 339921 run on x86_64-darwin 1

2 packages built:
  • vimPlugins.avante-nvim
  • vimPluginsUpdater

@GaetanLepage GaetanLepage merged commit 209272d into NixOS:master Sep 16, 2024
28 of 30 checks passed
@ttrei ttrei deleted the avante-nvim branch September 16, 2024 13:51
@elohmeier elohmeier mentioned this pull request Sep 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinnymeller vinnymeller vinnymeller approved these changes

@GaetanLepage GaetanLepage GaetanLepage approved these changes

@figsoda figsoda Awaiting requested review from figsoda figsoda is a code owner

@caarlos0 caarlos0 Awaiting requested review from caarlos0

@aarnphm aarnphm Awaiting requested review from aarnphm

Assignees
No one assigned
Labels
6.topic: vim 8.has: maintainer-list (update) 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@ttrei @vinnymeller @caarlos0 @nixos-discourse @aarnphm @GaetanLepage @wegank @NixOSInfra