Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nodle-parachain): set the dalek end block to be in future #704

Closed
wants to merge 1 commit into from

Conversation

aliXsed
Copy link
Contributor

@aliXsed aliXsed commented Feb 16, 2023

Closes #703

This comment suggest we may not need this extension. Therefore I create this PR as a draft and leave it to see if syncing a new node with the upcoming image would have any issues.

@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Merging #704 (b3aa36b) into master (121ef4b) will decrease coverage by 0.09%.
The diff coverage is 0.00%.

❗ Current head b3aa36b differs from pull request most recent head eeb2ff3. Consider uploading reports for the commit eeb2ff3 to get more accurate results

@@            Coverage Diff             @@
##           master     #704      +/-   ##
==========================================
- Coverage   78.20%   78.12%   -0.09%     
==========================================
  Files          43       43              
  Lines        7580     7588       +8     
==========================================
  Hits         5928     5928              
- Misses       1652     1660       +8     
Impacted Files Coverage Δ
node/src/service.rs 0.00% <0.00%> (ø)
runtimes/eden/src/version.rs 0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ETeissonniere
Copy link
Member

The Nodle App used to use ed25519 keys, legacy accounts still do so. I would be curious to see if this could pause issues with our transaction signatures, or if this is not relevant to us

@aliXsed
Copy link
Contributor Author

aliXsed commented Feb 22, 2023

The Nodle App used to use ed25519 keys, legacy accounts still do so. I would be curious to see if this could pause issues with our transaction signatures, or if this is not relevant to us

I have started a test with a node with using the new client to check if there would be any issues discovered there.

@aliXsed aliXsed marked this pull request as ready for review February 22, 2023 21:20
@simonsso
Copy link
Contributor

You remove some CI jobs here without a comment, is this a merge mistake or intentional

@aliXsed aliXsed marked this pull request as draft February 23, 2023 22:18
@aliXsed
Copy link
Contributor Author

aliXsed commented Feb 23, 2023

You remove some CI jobs here without a comment, is this a merge mistake or intentional

Yeah that was for the sake of temporarily removing any unneeded actions. I converted the PR back to draft to prevent from an accidental merge.

@aliXsed
Copy link
Contributor Author

aliXsed commented Feb 26, 2023

This PR is replaced by #709

@aliXsed aliXsed closed this Feb 26, 2023
@aliXsed aliXsed deleted the aliX/dalek-zebra branch February 28, 2023 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjust block number for ending usage of dalek
3 participants