Add GH secret for API key to try-runtime job #757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #757 +/- ##
=======================================
Coverage 59.00% 59.00%
=======================================
Files 38 38
Lines 4710 4710
=======================================
Hits 2779 2779
Misses 1931 1931 |
simonsso
force-pushed
the
chore/20230621-try-runtime-ci
branch
4 times, most recently
from
c8f36b6
to
63f03ca
Compare
simonsso
commented
Jun 22, 2023
| @@ -46,7 +46,7 @@ jobs: | |||
| if: github.event_name != 'pull_request' | |||
| uses: docker/login-action@v2 | |||
| with: | |||
| username: ${{ secrets.DOCKERHUB_USERNAME }} | |||
| username: ${{ vars.DOCKERHUB_USERNAME }} | |||
There was a problem hiding this comment.
Moved username from secrets so it can be printed
|
Looks good to me |
Add GH secret for API key to try-runtime job Move DockerHub username from secret to vars
simonsso
force-pushed
the
chore/20230621-try-runtime-ci
branch
from
63f03ca
to
5b3eeb4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.