forked from shaka-project/shaka-player
-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
ci: Test on Safari 14 (shaka-project#4095)
In the GitHub Actions environment, it is now possible to install and run tests on Safari 14. Though not completely straightforward, it doesn't add much code to the workflow and shouldn't be too difficult to maintain. Closes shaka-project#3899
- Loading branch information
1 parent
8ed53a3
commit cebb316
Showing
2 changed files
with
55 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
#!/bin/bash | ||
|
||
# A script to launch a homedir-installed copy of Safari in Karma. Used with | ||
# karma-script-launcher and --browsers path/to/script. | ||
|
||
# There is an issue where opening a URL in a browser that is not already open | ||
# will also open it in the default browser. See | ||
# https://apple.stackexchange.com/a/122000/454832 and the comments below it for | ||
# details. | ||
|
||
# The workaround is to open the browser explicitly first, without a URL. | ||
open -a ~/Applications/Safari.app --fresh | ||
sleep 5 | ||
|
||
# Then open the browser with the URL, and wait for it to quite. In fact, the | ||
# browser won't be closed automatically at all, and Karma will kill this script | ||
# when the tests complete. But if we don't wait, Karma will error instead. | ||
open -a ~/Applications/Safari.app --wait-apps "$1" |