Skip to content

Commit

Permalink
fix(ui): Fix cross-browser focus outline
Browse files Browse the repository at this point in the history
It turns out that `-webkit-focus-ring-color` is no longer working
across platforms in Chrome.  It works on Mac, but not anywhere else.

Removing it creates a consistent focus outline across browsers and
platforms.  It was only being used on Safari and Chrome anyway,
neither of which seem to need it.

Closes shaka-project#2863

Change-Id: Ic6df1a10f14a0907558595e53bef80ac349e6b9d
  • Loading branch information
joeyparrish committed Mar 18, 2021
1 parent 77054d2 commit f676fed
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions ui/less/buttons.less
Original file line number Diff line number Diff line change
Expand Up @@ -92,10 +92,6 @@
/* Most browsers will fall back to "Highlight" (system setting) color for
* the focus outline. */
outline: 1px solid Highlight;

/* WebKit-based and Blink-based browsers have this as their default outline
* color. */
outline: 1px solid -webkit-focus-ring-color;
}

/* Disable this Mozilla-specific focus ring, since we have an outline defined
Expand Down

0 comments on commit f676fed

Please sign in to comment.