-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): Design Prototype for split panel component #4378
Open
dan-rukas
wants to merge
13
commits into
master
Choose a base branch
from
feat/split-panel-design
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
testing new PanelSplit component functionality
Updated to include shadcn components and states for each list item in the panel
List items and properties panel working better with all items and individual items
Fixed alignment of elements and rows in the properties panel and list view. Added color styles.
Separates base components from design layouts and patterns
✅ Deploy Preview for ohif-platform-docs canceled.
|
✅ Deploy Preview for ohif-dev canceled.
|
Viewers Run #4282
Run Properties:
|
Project |
Viewers
|
Branch Review |
feat/split-panel-design
|
Run status |
Passed #4282
|
Run duration | 02m 47s |
Commit |
e8bbafa959: Added working visibility state toggles for items
|
Committer | Dan Rukas |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
2
|
Skipped |
0
|
Passing |
44
|
View all changes introduced in this branch ↗︎ |
This tab component now works like other components in the property panel and updates based on what is selected in the list
Currently hiding the stepper (up and down) for Input number field. This will be replaced in the future by a new component
Works on individual items and all items option will toggle visibility for all other items
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR includes an experimental coded component for the Split Panel design. The goal of this component is to share the final design states and intended behaviors.
Component Summary:
The
PanelSplit
component is designed to manage and display a list of items, each with customizable properties. It features an interactiveItemList
that allows users to select items and toggle their visibility individually or collectively through a master toggle. Upon selecting an item, thePropertiesPanel
provides adjustable settings, including (in this example) various display modes and controls for: Visibility, Fill & Outline, Opacity, Outline size.Features and Behaviors:
Design Prototype is located in ui-next (patterns page)
Work in progress: This component is not yet finalized. I’m actively iterating and open to suggestions for improvement.
This component is for internal review currently, not intended for production at this stage.
Changes & Results
Adds design prototype for Split Panel component
Testing
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment