Add optional remark param to placeOrder mutation #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added tests to cover new class, BeftoreAddItem and BeforeRemoveItem events
Simplify order remark saving mechanism
Signed-off-by: Anton Fedurtsya <anton@fedurtsya.com>
Signed-off-by: Anton Fedurtsya <anton@fedurtsya.com>
|
Hey @pvanhemmen, thanks for the pull request! I have changed a bit the place where the remark is set to the Order object and added a test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the possibility to add the order remark as an optional param to the placeOrder mutation since this was not possible yet. The remark will then be handled accordingly and saved with the order.