recording database updates #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It simplifies recording data and takes care of references
PlasmaPower
reviewed
Nov 2, 2022
| for ctx.Err() == nil { | ||
| block := r.bc.GetBlockByNumber(blockToRecreate) | ||
| if block == nil { | ||
| return nil, fmt.Errorf("block not found while recreating: %d", blockToRecreate) |
There was a problem hiding this comment.
We could check here if block.ParentHash() matches what we'd expect to provide early protection against reorgs, though I suppose checking that the state root matches is also good enough
There was a problem hiding this comment.
done. Worth noting, though, that most reorgs will only be found after we reach the block number we're originally looking for and comparing it with the param header
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This converges support needed for validation without an archive node.