Peterson implement improvements in team code input #2621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vigneshwar-Muriki
previously approved these changes
Aug 27, 2024
manikittu810
previously approved these changes
Aug 27, 2024
There was a problem hiding this comment.
Hello @peterson337
Everything is working as mentioned.
Thank you.
JatinAgrawal94
previously approved these changes
Aug 29, 2024
Jingyii800
previously approved these changes
Aug 30, 2024
Pranay-ai
requested changes
Aug 30, 2024
There was a problem hiding this comment.
Hey @peterson337
I have reviewed the PR But i have couple of Issues
The Team code is not being checked if it's a valid Code
Too many Toast Notifications For Each Char Added and Deleted
TEAM.AUTO.UPDATE.mp4
jinxyou
previously approved these changes
Aug 31, 2024
CillianRen
previously approved these changes
Sep 1, 2024
sri0606
requested changes
Sep 5, 2024
There was a problem hiding this comment.
Hey @peterson337 , I have reviewed the changes you made and found some issues:
- When I enter a character and choose an option from dropdown, I get the correct toaster message. But when I clear the team code to enter another, I get another toaster message saying "Team code updated"
- If I enter a invalid team code with enough characters, I get "Team code updated".
- It crashes/lags sometimes as you can see in video below. I had to refresh.
HGN.APP.-.Google.Chrome.2024-09-05.12-51-41.mp4
peterson337
added
the
do not review
peterson337
dismissed stale reviews from CillianRen, jinxyou, Jingyii800, JatinAgrawal94, manikittu810, and Vigneshwar-Muriki
via
f1bb8e3
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request has been opened to implement the auto-save feature in the team code input.
Related PRS (if any):
None
Main changes explained:
Three components (AutoCompleteTeamCode.jsx, UserTeamsTable.jsx and UserProfile.jsx) have been modified to implement the auto-save.
How to test:
npm installand...to run this PR locallyScreenshots or videos of changes:
Note:
None.